Add ability to parse a Takeout zip file and extract+import bookmarks #6820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2025
CDRussell
force-pushed
the
feature/craig/streamline_import_bookmarks_takeout_zip
branch
5 times, most recently
from
29e253d to
1b6e8bb
Compare
CDRussell
changed the title
CDRussell
changed the title
CDRussell
force-pushed
the
feature/craig/streamline_import_add_feature_flag
branch
from
eda2570 to
1b8cac9
Compare
CDRussell
force-pushed
the
feature/craig/streamline_import_bookmarks_takeout_zip
branch
from
1b6e8bb to
01d5515
Compare
cmonfortep
reviewed
Sep 22, 2025
...es/saved-sites-api/src/main/java/com/duckduckgo/savedsites/api/service/SavedSitesImporter.kt
Show resolved
Hide resolved
...java/com/duckduckgo/autofill/impl/importing/takeout/processor/TakeoutBookmarkImporterTest.kt
Show resolved
Hide resolved
...java/com/duckduckgo/autofill/impl/importing/takeout/processor/TakeoutBookmarkImporterTest.kt
Show resolved
Hide resolved
...pl/src/main/java/com/duckduckgo/autofill/impl/importing/takeout/zip/ZipEntryContentReader.kt
Show resolved
Hide resolved
cmonfortep
reviewed
Sep 22, 2025
CDRussell
changed the base branch from
feature/craig/streamline_import_add_feature_flag
to
graphite-base/6820
CDRussell
force-pushed
the
graphite-base/6820
branch
from
1b8cac9 to
59a1417
Compare
CDRussell
force-pushed
the
feature/craig/streamline_import_bookmarks_takeout_zip
branch
from
01d5515 to
1dfcbd0
Compare
graphite-app
bot
changed the base branch from
graphite-base/6820
to
develop
CDRussell
force-pushed
the
feature/craig/streamline_import_bookmarks_takeout_zip
branch
2 times, most recently
from
6f10a11 to
1dfcbd0
Compare
CDRussell
force-pushed
the
feature/craig/streamline_import_bookmarks_takeout_zip
branch
from
1dfcbd0 to
0322886
Compare
This was referenced Sep 23, 2025
CDRussell
deleted the
feature/craig/streamline_import_bookmarks_takeout_zip
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/608920331025315/task/1211197010246723?focus=true
Description
Adds ability to parse a Google Takeout zip file containing exported bookmarks. This PR only adds underlying logic and dev settings to test it; prod UI isn't changed.
Steps to test this PR
Importing a valid file
internalbuild typeAutofill Dev Settings, and scroll toImport Bookmarksdev settings 🆕Choose zip file (downloaded from Takeout)and choose the Takeout zip; verify the bookmarks imported using theView BookmarksbuttonImporting an invalid file
Choose zip file (downloaded from Takeout)and choose a random other file (either not a Takeout zip or one that doesn't contain bookmarks) and verify it just reports it as invalid as a snackbarInstructions for generating a Takeout zip file
Tap
Launch Google Takeout (normal tab)fromAutofill Dev Settingsand use this to generate a zip file for testing:- [ ] sign in
- [ ] Tap on
Deselect All- [ ] Scroll down to
Chrome, and check it- [ ] Optionally, Tap on
All Chrome data includedand choose only bookmarks- [ ] Scroll all the way down to the bottom and tap
Next step- [ ] Leave all settings as is, and choose
Create export- [ ] Wait a few seconds, then refresh the page until you see
Your latest exportshows the export you just created (at the top of the page)- [ ] Tap
Downloadand confirm you want to save it